🔧 Gate SpinConfigStore on the spin feature: spin-sdk is an optional dependency enabled only by the spin feature, but this wasm32 arm is gated only on target_arch = "wasm32". As a result, cargo check -p edgezero-adapter-spin --target wasm32-wasip1 --no-default-features currently fails here with unresolved import spin_sdk.

Suggestion: gate the production backend consistently on both cfgs, and update the fallback branch to match:

#[cfg(all(feature = "spin", target_arch = "wasm32"))]
Spin,

#[cfg(all(feature = "spin", target_arch = "wasm32"))]
pub fn new() -> Self { ... }

#[cfg(all(feature = "spin", target_arch = "wasm32"))]
SpinConfigBackend::Spin => { ... }

🔧 Resolve Spin store handles from the manifest: run_app reaches this path, so Spin always opens the hard-coded "default" KV label and always injects config/secrets. That bypasses [stores.kv].name, [stores.kv.adapters.spin], [stores.secrets].enabled, and whether [stores.config] exists, unlike the Fastly and Cloudflare run_app(manifest_src, ...) paths. A user setting [stores.kv] name = "MY_KV" would still get no KV handle unless they manually avoid run_app and call dispatch_with_kv_label themselves.

Suggestion: add a manifest-aware Spin entry point that resolves manifest.kv_store_name(edgezero_core::app::SPIN_ADAPTER), manifest.secret_store_enabled(...), and config-store presence before dispatching, then update the Spin template to pass the embedded edgezero.toml manifest.

🔧 Do not report TTL writes as successful when Spin cannot expire them: put_bytes_with_ttl logs a warning but then writes the value without any expiry and returns Ok(()). The core KV contract says TTL values should be treated as expired after the TTL, so callers can accidentally retain temporary/session data indefinitely without any error signal.

Suggestion: return an explicit validation/unsupported error instead of writing when TTL cannot be honored:

return Err(KvError::Validation(
    "Spin KV does not support TTL; use put_bytes for non-expiring values".to_string(),
));

🔧 Apply bounded-listing semantics before fetching keys: Store::get_keys() materializes the entire Spin KV store before max_list_keys is checked, so the cap does not actually prevent unbounded allocation in the request path. This also conflicts with the core KvStore::list_keys_page contract, which says implementations should keep memory bounded to a single page of keys.

Suggestion: unless Spin exposes prefix/server-side pagination, treat key listing as unsupported for this adapter rather than fetching the whole store:

Err(KvError::Validation(
    "Spin KV key listing is unsupported because Store::get_keys() is unbounded".to_string(),
))

🔧 Keep the config-store adapter docs aligned with validation: this rustdoc now says [stores.config.adapters] can be keyed by spin, but SUPPORTED_CONFIG_STORE_ADAPTERS intentionally excludes spin and the new test expects [stores.config.adapters.spin] to fail validation. That will mislead users into writing a manifest shape that EdgeZero rejects.

Suggestion: remove spin from this list and call out the reason, e.g. Spin config uses component variables in a flat namespace, so stores.config.adapters.spin is rejected.